Latin1 support for SASL DIGEST-MD5 (second, and possibly final commit)

Mon, 08 Dec 2008 00:18:01 +0500

author
Waqas Hussain <waqas20@gmail.com>
date
Mon, 08 Dec 2008 00:18:01 +0500
changeset 599
30655c5cc531
parent 595
08ed4fa2f89d
child 600
2255a2e84ddc

Latin1 support for SASL DIGEST-MD5 (second, and possibly final commit)

plugins/mod_saslauth.lua file | annotate | diff | comparison | revisions
util/sasl.lua file | annotate | diff | comparison | revisions
--- a/plugins/mod_saslauth.lua	Sun Dec 07 23:43:08 2008 +0500
+++ b/plugins/mod_saslauth.lua	Mon Dec 08 00:18:01 2008 +0500
@@ -66,15 +66,14 @@
 	end
 end
 
-local function password_callback(node, host, mechanism, raw_host)
-	log("host", host);
-	log("raw_host", raw_host);
-	local password = (datamanager.load(node, raw_host, "accounts") or {}).password; -- FIXME handle hashed passwords
+local function password_callback(node, host, mechanism, decoder)
+	local password = (datamanager.load(node, host, "accounts") or {}).password; -- FIXME handle hashed passwords
 	local func = function(x) return x; end;
 	if password then
 		if mechanism == "PLAIN" then
 			return func, password;
 		elseif mechanism == "DIGEST-MD5" then
+			if decoder then node, host, password = decoder(node), decoder(host), decoder(password); end
 			return func, md5(node..":"..host..":"..password);
 		end
 	end
--- a/util/sasl.lua	Sun Dec 07 23:43:08 2008 +0500
+++ b/util/sasl.lua	Mon Dec 08 00:18:01 2008 +0500
@@ -177,11 +177,10 @@
 			if not response["qop"] then response["qop"] = "auth" end
 			
 			if response["realm"] == nil then response["realm"] = "" end
-			local raw_realm = response["realm"];
+			local decoder;
 			
 			if response["charset"] == nil then
-				response["username"] = latin1toutf8(response["username"])
-				response["realm"] = utf8tolatin1ifpossible(response["realm"])
+				decoder = utf8tolatin1ifpossible;
 			elseif response["charset"] ~= "utf-8" then
 				return "failure", "incorrect-encoding", "The client's response uses "..response["charset"].." for encoding with isn't supported by sasl.lua. Supported encodings are latin or utf-8."
 			end
@@ -197,7 +196,7 @@
 			
 			--TODO maybe realm support
 			self.username = response["username"]
-			local password_encoding, Y = self.password_handler(response["username"], response["realm"], "DIGEST-MD5", raw_realm)
+			local password_encoding, Y = self.password_handler(response["username"], response["realm"], "DIGEST-MD5", decoder)
 			if Y == nil then return "failure", "not-authorized"
 			elseif Y == false then return "failure", "account-disabled" end
 			

mercurial