Fix potential stack slot leak when error occurs

Mon, 07 Dec 2009 22:48:43 +0000

author
Matthew Wild <mwild1@gmail.com>
date
Mon, 07 Dec 2009 22:48:43 +0000
changeset 71
3e56f21e2e28
parent 70
004edb92a6e8
child 72
adb5fa9ea85a

Fix potential stack slot leak when error occurs

src/buffer_event.c file | annotate | diff | comparison | revisions
--- a/src/buffer_event.c	Mon Dec 07 22:45:12 2009 +0000
+++ b/src/buffer_event.c	Mon Dec 07 22:48:43 2009 +0000
@@ -49,7 +49,12 @@
 	/* func, bufferevent */
 	lua_pushinteger(L, what);
 	/* What to do w/ errors...? */
-	lua_pcall(L, 2, 0, 0);
+	if(!lua_pcall(L, 2, 0, 0))
+	{
+		/* FIXME: Perhaps luaevent users should be
+		 * able to set an error handler? */
+		lua_pop(L, 1); /* Pop error message */
+	}
 }
 
 static void buffer_event_readcb(struct bufferevent *ev, void *ptr) {

mercurial