mod_saslauth: Don't print raw SASL data to avoid logging passwords unnecessarily

Sat, 13 Feb 2010 19:35:12 +0000

author
Matthew Wild <mwild1@gmail.com>
date
Sat, 13 Feb 2010 19:35:12 +0000
changeset 2860
ad534f89c758
parent 2859
460681180194
child 2861
1402615b66f8

mod_saslauth: Don't print raw SASL data to avoid logging passwords unnecessarily

plugins/mod_saslauth.lua file | annotate | diff | comparison | revisions
--- a/plugins/mod_saslauth.lua	Sat Feb 13 16:22:05 2010 +0000
+++ b/plugins/mod_saslauth.lua	Sat Feb 13 19:35:12 2010 +0000
@@ -38,13 +38,13 @@
 local function build_reply(status, ret, err_msg)
 	local reply = st.stanza(status, {xmlns = xmlns_sasl});
 	if status == "challenge" then
-		log("debug", "%s", ret or "");
+		--log("debug", "CHALLENGE: %s", ret or "");
 		reply:text(base64.encode(ret or ""));
 	elseif status == "failure" then
 		reply:tag(ret):up();
 		if err_msg then reply:tag("text"):text(err_msg); end
 	elseif status == "success" then
-		log("debug", "%s", ret or "");
+		--log("debug", "SUCCESS: %s", ret or "");
 		reply:text(base64.encode(ret or ""));
 	else
 		module:log("error", "Unknown sasl status: %s", status);
@@ -121,7 +121,7 @@
 	local text = stanza[1];
 	if text then
 		text = base64.decode(text);
-		log("debug", "%s", text);
+		--log("debug", "AUTH: %s", text:gsub("[%z\001-\008\011\012\014-\031]", " "));
 		if not text then
 			session.sasl_handler = nil;
 			session.send(build_reply("failure", "incorrect-encoding"));

mercurial