# HG changeset patch
# User Matthew Wild <mwild1@gmail.com>
# Date 1269222862 0
# Node ID 4d9a73abb237ff5ba704056fde6b50424389a510
# Parent  b924d915c4d0a763b93ab9dfa5708143ba5404aa
mod_roster: Tidier code for the roster versioning logic

diff -r b924d915c4d0 -r 4d9a73abb237 plugins/mod_roster.lua
--- a/plugins/mod_roster.lua	Sat Mar 20 14:16:33 2010 +0000
+++ b/plugins/mod_roster.lua	Mon Mar 22 01:54:22 2010 +0000
@@ -36,9 +36,10 @@
 				if stanza.attr.type == "get" then
 					local roster = st.reply(stanza);
 					
-					local ver = stanza.tags[1].attr.ver
+					local client_ver = tonumber(stanza.tags[1].attr.ver);
+					local server_ver = tonumber(session.roster[false].version or 1);
 					
-					if (not ver) or tonumber(ver) ~= (session.roster[false].version or 1) then
+					if not (client_ver and server_ver) or client_ver ~= server_ver then
 						roster:query("jabber:iq:roster");
 						-- Client does not support versioning, or has stale roster
 						for jid in pairs(session.roster) do
@@ -55,7 +56,7 @@
 								roster:up(); -- move out from item
 							end
 						end
-						roster.tags[1].attr.ver = tostring(session.roster[false].version or "1");
+						roster.tags[1].attr.ver = server_ver;
 					end
 					session.send(roster);
 					session.interested = true; -- resource is interested in roster updates