# HG changeset patch
# User Waqas Hussain <waqas20@gmail.com>
# Date 1276272077 -18000
# Node ID 362b94fa5a30245c7032234942e7191642706a6d
# Parent  721a83a3beb9fd7fb9e6da1b81617c754a7e9fb3
mod_saslauth: Return proper error on invalid usernames.

diff -r 721a83a3beb9 -r 362b94fa5a30 plugins/mod_saslauth.lua
--- a/plugins/mod_saslauth.lua	Fri Jun 11 20:35:10 2010 +0500
+++ b/plugins/mod_saslauth.lua	Fri Jun 11 21:01:17 2010 +0500
@@ -109,17 +109,17 @@
 		session.sasl_handler = session.sasl_handler:clean_clone();
 	elseif status == "success" then
 		local username = nodeprep(session.sasl_handler.username);
-		if not username then -- TODO move this to sessionmanager
-			module:log("warn", "SASL succeeded but we didn't get a username!");
-			session.sasl_handler = nil;
-			session:reset_stream();
-			return status, ret, err_msg;
-		end
 
 		if not(require_provisioning) or usermanager_user_exists(username, session.host) then
-			sm_make_authenticated(session, session.sasl_handler.username);
-			session.sasl_handler = nil;
-			session:reset_stream();
+			local aret, err = sm_make_authenticated(session, session.sasl_handler.username);
+			if aret then
+				session.sasl_handler = nil;
+				session:reset_stream();
+			else
+				module:log("warn", "SASL succeeded but username was invalid");
+				session.sasl_handler = session.sasl_handler:clean_clone();
+				return "failure", "not-authorized", "User authenticated successfully, but username was invalid";
+			end
 		else
 			module:log("warn", "SASL succeeded but we don't have an account provisioned for %s", username);
 			session.sasl_handler = session.sasl_handler:clean_clone();