changelog
- Sun, 20 Jul 2008 21:39:39 -0400
- by Brett Smith <brettcsmith@brettcsmith.org> [Sun, 20 Jul 2008 21:39:39 -0400] rev 80
- Move more common extraction/listing functionality into BaseExtractor.
I noticed that a lot of the extract_archive/get_filenames implementations
were the same two lines of code: a pipe and a run_pipes. Short as it is,
there's no reason to keep repeating that two-line incantation, so I moved
this basic pattern into BaseExtractor.
- Sun, 20 Jul 2008 21:16:08 -0400
- by Brett Smith <brettcsmith@brettcsmith.org> [Sun, 20 Jul 2008 21:16:08 -0400] rev 79
- Improve dtrx -l performance on misnamed files, and clean other error messages.
dtrx -l would only ever try one extractor, instead of trying all possible
alternaitves like it did when extracting. This is mostly because
get_filenames() reported no meaningful error information. This has been
fixed.
Some error messages have been genericized, since we're not always
extracting archives: we might be listing their contents instead.
- Sun, 20 Jul 2008 20:45:54 -0400
- by Brett Smith <brettcsmith@brettcsmith.org> [Sun, 20 Jul 2008 20:45:54 -0400] rev 78
- Don't show errors from failed extractors unless they all fail.
If dtrx has to try different extractors before finding and using the right
one, the user shouldn't see error messages from the failed extractors;
those are just confusing. Just like the Application decides whether to say
particular extractors failed at all, this patch makes it also decide
whether or not to show the stderr from those extractors.
