TODO@16506464d57b
TODO
Sun, 20 Jan 2008 15:32:02 -0500
- author
- brett
- date
- Sun, 20 Jan 2008 15:32:02 -0500
- branch
- trunk
- changeset 58
- 16506464d57b
- parent 52
- cf191f957fd0
- child 61
- 23eb5e0a6665
- permissions
- -rw-r--r--
[svn] Steel FilenameChecker against race conditions.
Since FilenameChecker was just using os.path.exists() to see whether or not
a filename was free, it had a time of check vs. time of use vulnerability.
Matthew was prodding me about the inconsistency with DirectoryChecker, so
that inspired me to fix this. This also entailed some refactoring. Thanks
Matthew.
To do: * Add ability to list included archives for recursive extraction Things which I have a use case/anti-use case for: * Support pisi packages (http://paketler.pardus.org.tr/pardus-2007/) * Steal ideas from <http://martin.ankerl.com/files/e>. * More consistently raise and handle exceptions. Things that are generally good: * Better tests. * Better error messages. Things I think might be good but can't prove: * Consider having options about whether or not to make sane directories, have tarbomb protection, etc. * Use zipfile instead of the zip commands. * Processing from stdin. * shar support.
