Sun, 20 Jul 2008 21:39:39 -0400
Move more common extraction/listing functionality into BaseExtractor.
I noticed that a lot of the extract_archive/get_filenames implementations
were the same two lines of code: a pipe and a run_pipes. Short as it is,
there's no reason to keep repeating that two-line incantation, so I moved
this basic pattern into BaseExtractor.
61 | 1 | -*- text -*- |
2 | ||
45
37d555407334
[svn] At work I was getting an unhelpful "No such file or directory" error when I
brett
parents:
40
diff
changeset
|
3 | To do: |
61 | 4 | |
77
3a1f49be7667
Clean the target directory if an extraction attempt failed.
Brett Smith <brettcsmith@brettcsmith.org>
parents:
72
diff
changeset
|
5 | * Investigate the right way to handle SIGPIPE and do so. |
61 | 6 | |
68 | 7 | * --expert mode: prompts don't show an explanation of what the options are, |
8 | unless you ask with ?. | |
67
1b4ca6de7740
Update TODO: remove complete tasks, add new items.
Brett Smith <brett@brettcsmith.org>
parents:
65
diff
changeset
|
9 | |
3 | 10 | Things which I have a use case/anti-use case for: |
22
b240777ae53e
[svn] Improve the way we check archive contents. If all the entries look like
brett
parents:
18
diff
changeset
|
11 | * Support pisi packages (http://paketler.pardus.org.tr/pardus-2007/) |
b240777ae53e
[svn] Improve the way we check archive contents. If all the entries look like
brett
parents:
18
diff
changeset
|
12 | * Steal ideas from <http://martin.ankerl.com/files/e>. |
40
ee6a869f8da1
[svn] Be a little nicer about explaining that we can't extract to the current
brett
parents:
35
diff
changeset
|
13 | * More consistently raise and handle exceptions. |
3 | 14 | |
15 | Things that are generally good: | |
6
77043f4e6a9f
[svn] The big thing here is recursive extraction. Find archive files in the
brett
parents:
5
diff
changeset
|
16 | * Better tests. |
5 | 17 | * Better error messages. |
3 | 18 | |
19 | Things I think might be good but can't prove: | |
8
97388f5ff770
[svn] Make ExtractorApplication suck less. Now the strategies for handling
brett
parents:
7
diff
changeset
|
20 | * Consider having options about whether or not to make sane directories, |
97388f5ff770
[svn] Make ExtractorApplication suck less. Now the strategies for handling
brett
parents:
7
diff
changeset
|
21 | have tarbomb protection, etc. |
3 | 22 | * Use zipfile instead of the zip commands. |
23 | * Processing from stdin. | |
18
1600807a32bd
[svn] Add basic documentation, and make this version 3.0.
brett
parents:
13
diff
changeset
|
24 | * shar support. |